Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves issue#59 - Treat None values as non-existing keys for default_box #108

Merged
merged 4 commits into from
Oct 22, 2019

Conversation

haruntuncay
Copy link

Solves the issue #59.

@pep8speaks
Copy link

pep8speaks commented Oct 19, 2019

Hello @haruntuncay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 389:15: F405 'Box' may be undefined, or defined from star imports: .common, test.common
Line 393:15: F405 'Box' may be undefined, or defined from star imports: .common, test.common

Comment last updated at 2019-10-22 06:48:09 UTC

@coveralls
Copy link

coveralls commented Oct 19, 2019

Coverage Status

Coverage increased (+0.007%) to 97.698% when pulling 247f240 on haruntuncay:4.0_issue#59 into f02367d on cdgriffith:4.0.

@haruntuncay
Copy link
Author

Hello @cdgriffith , when you have the time, could you please check out this PR ? Thanks in advance.

@haruntuncay
Copy link
Author

@cdgriffith Thank you so much for the review. Do you have any idea what should I do in order to increase code coverage ?

@cdgriffith
Copy link
Owner

Don't need to worry about that for now, I am still finishing a few things off / re-arraigning for 4.0 so that is something to address last. I'll merge this later today, just will give you a bit if you want to add yourself to authros file with a commit (I will do it myself later, just don't want to forget!)

@cdgriffith cdgriffith merged commit 145a10f into cdgriffith:4.0 Oct 22, 2019
cdgriffith pushed a commit that referenced this pull request Dec 18, 2019
…box (#108)

* Solves issue#59 - Treat None values as non-existing keys for default_box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants