Feature: quietDown and cancelQuietDown #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@P01son6415 LGTM. I'll give things a bit to let @martinda chime in if he has any thoughts. If not then I'll merge later today. |
|
All tests pass as expected. Merging now. Thanks for the PR @P01son6415 !!! |
|
@P01son6415 version |
|
Thanks. Sorry for being late to the party, just catching up on emails. |
|
@martinda that's been me the past 6 months :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #53
quietDown sends the Quiet Down (Prepare for shutdown) message to Jenkins
cancelQuietDown cancels the Quiet Down message
These two endpoints should be tested together, so I put them in one Pull Request.