CrumbIssuer.crumb now returns boxed version of its former self so tha… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t we can check whether or not the request contained errors or not.
|
I tried it today and it worked as expected. Thank you! |
martinda
referenced
this pull request
in martinda/cdancy-jenkins-rest
Dec 5, 2021
martinda
referenced
this pull request
in martinda/cdancy-jenkins-rest
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinda this PR addresses #14 . The
CrumbIssuer.crumbendpoint can now be checked forerrors(). We then take advantage of this in the authentication filter to check whether the call returns a 404/ResourceNotFoundException and if so simply ignore adding the crumb to the request otherwise throw an exception with theerrorattached.Check it out and let me know what you think.