Upgrade to Gradle 6.7.1, shadow 6.1.0, jfrog build info extractor 4.18.3 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdancy
reviewed
Jan 12, 2021
| @@ -18,7 +18,6 @@ publishing { | |||
| artifact sourcesJar | |||
| artifact testsJar | |||
| artifact javadocJar | |||
| artifact shadowJar | |||
There was a problem hiding this comment.
@martinda why did we remove this? Will the shadow jar still got published if we remove it?
And apologies for the late responses ... just getting back into the swing of things now from the holidays.
There was a problem hiding this comment.
Hello @cdancy . It is automatically added since version shadow version 6.1.0 [PR #357]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing the following upgrades:
plugins { ... }form of declaring pluginscom.github.jengelman.gradle.plugins:shadow:2.0.2toid 'com.github.johnrengelman.shadow' version '6.1.0'