Paging api #19
Paging api #19
Conversation
| @@ -1,5 +1,5 @@ | |||
| group = com.cdancy | |||
| version = 0.0.10 | |||
| version = 0.0.10-pjr | |||
There was a problem hiding this comment.
Could we set the version to 0.0.10-SNAPSHOT instead to enforce the fact that this version is not yet released ?
| @@ -1,5 +1,5 @@ | |||
| group = com.cdancy | |||
| version = 0.0.10-pjr | |||
| version = 0.0.10-SNAPSHOT | |||
There was a problem hiding this comment.
In fact, it should actually be 0.0.11-SNAPSHOT, since version 0.0.10 is already released, and you targeted this PR to v0.0.11 milestone.
Test is more relevant than including parameters in expected path as param order is not significative. Also discard silently empty params.
|
Added mock and live test as expected. Mock test pass with success. For live test, I wait on Travis check |
|
@Gawen-pjr live tests are not wired together on travis. This is more due to Bitbucket and standing up an instance requires a license (I use a dev license for local development when necessary otherwise I connect to an instance we use here at work). Either way, I'll give the tests a live run tomorrow morning and see how things fare. Thanks AOT! |
|
Integration tests pass as expected. Thanks @Gawen-pjr !!! Did you need a new release with this change? |
|
Not yet. Still adding new features. I'll come back with a new PR soon ;-) |
|
@Gawen-pjr very good and thanks! Have you previously worked with jclouds before? I'm assuming yes just wanted to be sure. We're a small group all things considered. I ask because I've started another project api-processor which is an attempt to factor out the core processing of jclouds (the part which turns |
|
It was acually my first time with jclouds, but I'm quite used to play with meta-programming, so I had no problem to understand it's philosophy. For your other project, I'll take a peek as you suggested. But I can't engage myself, as I don't know if I'll have enough time for it. I have my own business and customers to manage... |
Opening another PR. Seems I did a false maneuver integrating your comments...
Sorry for the lost remarks...