Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Support for Qiskit v1.0.0 #210

Merged
merged 32 commits into from
Apr 16, 2024
Merged

🎨 Support for Qiskit v1.0.0 #210

merged 32 commits into from
Apr 16, 2024

Conversation

nquetschlich
Copy link
Collaborator

@nquetschlich nquetschlich commented Mar 15, 2024 •
edited
Loading

This PR:

  • updates MQT Predictor to Qiskit v1
  • improves the ruff config
  • removes device configuration files which are now part of MQT Bench

@nquetschlich nquetschlich added the enhancement New feature or request label Mar 15, 2024
@nquetschlich nquetschlich self-assigned this Mar 15, 2024
@nquetschlich nquetschlich added the minor Part of a minor release label Mar 15, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.6%. Comparing base (38d0f7a) to head (bc73c69).
Report is 2 commits behind head on main.

Files Patch % Lines
src/mqt/predictor/ml/predictor.py 84.2% 3 Missing ⚠️
src/mqt/predictor/rl/predictorenv.py 87.5% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #210     +/-   ##
=======================================
+ Coverage   79.4%   79.6%   +0.2%     
=======================================
  Files         12      12             
  Lines        982     965     -17     
=======================================
- Hits         780     769     -11     
+ Misses       202     196      -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nquetschlich
Copy link
Collaborator Author

waiting for CQCL/pytket-qiskit#256 to be solved and a new release of BQSKit that includes BQSKit/bqskit#228.

nquetschlich and others added 13 commits April 3, 2024 08:58
@nquetschlich nquetschlich marked this pull request as ready for review April 15, 2024 15:33
@nquetschlich nquetschlich requested a review from burgholzer April 15, 2024 15:33
burgholzer
burgholzer requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. Overall, this looks good to me! Just some minor recommendations.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@nquetschlich @burgholzer
Update pyproject.toml
270d3c4 
Co-authored-by: Lukas Burgholzer <[email protected]>
burgholzer
burgholzer approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now! Also thanks for adjusting the configuration and fixing all the things that popped up. 🙏🏼

@nquetschlich nquetschlich requested a review from burgholzer April 16, 2024 08:48
@nquetschlich nquetschlich merged commit b735d2a into main Apr 16, 2024
13 checks passed
@nquetschlich nquetschlich deleted the qiskit_v1_update branch April 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer Awaiting requested review from burgholzer

Assignees

@nquetschlich nquetschlich

Labels
enhancement New feature or request minor Part of a minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquetschlich @burgholzer