Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 smaller Python wheels #377

Merged
merged 1 commit into from
May 24, 2024
Merged

📦 smaller Python wheels #377

merged 1 commit into from
May 24, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR reduces the binary wheel size for the project by only installing the specific python bindings CMake component.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <[email protected]>
@burgholzer burgholzer added python Pull requests that update Python code packaging Anything related to Python packaging labels May 24, 2024
@burgholzer burgholzer self-assigned this May 24, 2024
@burgholzer burgholzer enabled auto-merge (squash) May 24, 2024 12:02
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.5%. Comparing base (025966a) to head (3790f21).
Report is 49 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #377     +/-   ##
=======================================
- Coverage   92.5%   92.5%   -0.1%     
=======================================
  Files         37      37             
  Lines       2561    2561             
  Branches     309     309             
=======================================
- Hits        2371    2370      -1     
- Misses       190     191      +1     
Flag Coverage Δ
cpp 94.5% <ø> (-0.1%) ⬇️
python 87.3% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 6d493d3 into main May 24, 2024
35 checks passed
@burgholzer burgholzer deleted the smaller-wheels branch May 24, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Anything related to Python packaging python Pull requests that update Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant