Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 fixes for noise-aware simulation in DDSIM #551

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR contains a couple of fixes for the noise-aware simulation techniques currently being reworked in cda-tum/mqt-ddsim#321.

More precisely, this PR makes sure that the corresponding DD package configs are already defined in the mqt-core library and that explicit instantiations for the methods relevant for DDSIM are in place.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added fix Fix for something that isn't working DD Anything related to the DD package c++ Anything related to C++ code labels Feb 12, 2024
@burgholzer burgholzer added this to the DD Package Improvements milestone Feb 12, 2024
@burgholzer burgholzer self-assigned this Feb 12, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 97.07113% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 91.1%. Comparing base (1db2860) to head (9c377f4).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #551   +/-   ##
=====================================
  Coverage   91.1%   91.1%           
=====================================
  Files        131     132    +1     
  Lines      13761   13794   +33     
  Branches    2164    2166    +2     
=====================================
+ Hits       12539   12573   +34     
+ Misses      1222    1221    -1     
Flag Coverage Δ
cpp 90.8% <97.0%> (+<0.1%) ⬆️
python 99.5% <ø> (ø)
Files Coverage Δ
include/mqt-core/dd/NoiseFunctionality.hpp 100.0% <ø> (+4.3%) ⬆️
src/dd/FunctionalityConstruction.cpp 96.8% <ø> (-0.8%) ⬇️
src/dd/NoiseFunctionality.cpp 97.0% <97.0%> (ø)

... and 3 files with indirect coverage changes

@burgholzer burgholzer merged commit 8c199aa into main Feb 23, 2024
37 checks passed
@burgholzer burgholzer deleted the dd-noise-fixes branch February 23, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package fix Fix for something that isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant