fix: accept false for data:

ccontrols · Feb 28, 2020 · 1ec10ba · 1ec10ba
1 parent d1f8f85
commit 1ec10ba
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/blocks/core/src/Source/Source.stories.tsx b/blocks/core/src/Source/Source.stories.tsx
@@ -63,6 +63,7 @@ simpleSource.story = {
     />
   );
 };`,
+        data: null,
       },
     },
   },

diff --git a/blocks/core/src/StorySource/StorySource.tsx b/blocks/core/src/StorySource/StorySource.tsx
@@ -123,7 +123,7 @@ export const StorySource: FC<StorySourceProps> = ({
   if (parentTheme === undefined) {
     actions.push({ title: themeName, onClick: onRotateTheme });
   }
-  if (args) {
+  if (args && args.length) {
     actions.push({ title: viewStyle, onClick: onMergeValues });
   }
 

diff --git a/core/core/src/randomizeData.ts b/core/core/src/randomizeData.ts
@@ -39,7 +39,7 @@ export const randomizeData = (
     .map(name => {
       const control = controls[name];
       const { data } = control;
-      if (data === null) {
+      if (data === false || data === null) {
         return null;
       }
       // check if control has custom settings for generating data

diff --git a/core/specification/src/controls.ts b/core/specification/src/controls.ts
@@ -174,9 +174,10 @@ export interface ComponentControlBase<T> {
 
   /**
    * helper information to generate random data
-   * can be used in conjunction with faker.js
+   * will be used in conjunction with faker.js
+   * datacan be set to false, if the control should not be randomized
    */
-  data?: ComponentControlData | null;
+  data?: ComponentControlData | null | false;
 }
 
 export interface ComponentControlText extends ComponentControlBase<string> {
-Original file line number
+Diff line change
@@ Expand Up / @@ -63,6 +63,7 @@ simpleSource.story = { @@
         />
       );
     };`,
+            data: null,
           },
         },
       },
@@ Expand Down @@