Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Puppet 4, Puppet 5 and Puppet 6 (EOL) #15

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Drop Puppet 4, Puppet 5 and Puppet 6 (EOL) #15

merged 3 commits into from
Jun 28, 2023

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Jun 15, 2023

smortex added 3 commits June 15, 2023 06:43
@smortex
Allow puppetlabs/concat 9.x
60059ec
@smortex
Fix CI
9c7884c 
When ccin2p3#13 was merged, the CI was not in place and I tested the change on
my production site which does not use these two classes.
@smortex
Drop Puppet 4, Puppet 5 and Puppet 6 (EOL)
946c473
@smortex smortex requested a review from a team as a code owner June 15, 2023 18:27
@smortex smortex mentioned this pull request Jun 15, 2023
Merged
faxm0dem
faxm0dem approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@faxm0dem faxm0dem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex merged commit 946c473 into ccin2p3:master Jun 28, 2023
@smortex smortex deleted the puppet456 branch July 12, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faxm0dem faxm0dem faxm0dem approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smortex @faxm0dem