New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

274 super select pr feedback #12

Merged

cchaos merged 3 commits into cchaos:274-super-select from chandlerprall:274-super-select-pr-feedback

Aug 14, 2018

chandlerprall commented Aug 14, 2018

addressing feedback on elastic#921

swapped if...else block for switch
changed hidden select element to an input type=hidden, as the select's display was set to none which prevented the value from being included in a form submit
modified the super_select_basic example to demonstrate disabled and data-test-subj attributes on options

chandlerprall added 3 commits

August 14, 2018 10:58


          use switch over if...else

2a7f5da


          Convert the hidden <select> into an input[type=hidden]

70d08c3


          Add example of disabled and data-test-subj attributes to a super sele…

5e86527

…ct example

cchaos merged commit 249fa1a into cchaos:274-super-select

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet