Support binding specified IP #51
Conversation
main.go
Outdated
| @@ -24,7 +24,8 @@ import ( | |||
|
|
|||
| func main() { | |||
| var serverAddr = flag.String("s", stun.DefaultServerAddr, "STUN server address") | |||
| var localPort = flag.Int("p", 0, "The port on which to bind requests, set to 0 to pick a random port") | |||
| var localPort = flag.Int("p", 0, "The ip on which to bind requests, set to empty will keep default") | |||
| var localIP = flag.String("i", "", "") | |||
There was a problem hiding this comment.
Why not have one addreess that takes an address with a port?
There was a problem hiding this comment.
Because in some cases you only need to specify the port, not the IP?
There was a problem hiding this comment.
You could still do "192.168.0.10:0" or ":5738" or both etc.
stun/client.go
Outdated
| if c.localPort != 0 { | ||
| laddr, err = net.ResolveUDPAddr("udp", fmt.Sprintf(":%d", c.localPort)) | ||
| address += strconv.Itoa(c.localPort) |
There was a problem hiding this comment.
i think we need a : between ip and port
There was a problem hiding this comment.
Yes, you're right, I forgot about this
stun/client.go
Outdated
| address += strconv.Itoa(c.localPort) | ||
| } | ||
|
|
||
| if c.localPort != 0 { |
There was a problem hiding this comment.
why do we not put the two if c.localPort != 0 { together?
There was a problem hiding this comment.
I've taken care of it and look better now
xlch88
force-pushed
the
master
branch
2 times, most recently
from
f107d31
to
4095b02
Compare
stun/client.go
Outdated
| laddr, err = net.ResolveUDPAddr("udp", fmt.Sprintf(":%d", c.localPort)) | ||
|
|
||
| if c.localPort != 0 || c.localIP != "" { | ||
| var address = c.localIP + ":" + strconv.Itoa(c.localPort) |
There was a problem hiding this comment.
| var address = c.localIP + ":" + strconv.Itoa(c.localPort) | |
| var address = fmt.Sprintf("%s:%d", c.localIP, c.localPort) |
stun/client.go
Outdated
| if c.localPort != 0 { | ||
| laddr, err = net.ResolveUDPAddr("udp", fmt.Sprintf(":%d", c.localPort)) | ||
| if c.localPort != 0 || c.localIP != "" { | ||
| var address = c.localIP + ":" + strconv.Itoa(c.localPort) |
|
lgtm after fixing the above minor issues |
|
What about ipv6 addresses? |
|
ipv6 doesn't have NAT |
|
merge ? |
No description provided.