Add testing check for Codebook row counts

[sam-pullman]

In the VariableCodebook, the 'Count' value represents the row counts for each variable.
In containerBuildTests.R, create an additional test to verify these counts.
Failure of this test would represent an issue with the CDC file, not necessarily a failure of the ETL process.

Up for discussion: Should this test abort the build process, or just print the info to the console?

[sam-pullman]

If this is valuable enough information to store inside the db, I can create a new metadata table similar to Meatdata.DownloadErrors that catalogs the Variable, TableName, CodeOrValue, ValueDescription, ExpectedCount, and DBCount. Thoughts @rgentlem @nathan-palmer ?

[rgentlem]

Hi Sam, nice work - and it might be, but at this point I would focus on getting the Minimal Viable Product (MVP) out. Add this in later if we ever find a situation where we want it. We are now at the point where seeing if we can get a user community is the most important part. That will help guide any future developments Nathan - any thoughts?

…

On Fri, Sep 22, 2023 at 3:17 PM Sam Pullman ***@***.***> wrote: If this is valuable enough information to store inside the db, I can create a new metadata table similar to Meatdata.DownloadErrors that catalogs the Variable, TableName, CodeOrValue, ValueDescription, ExpectedCount, and DBCount. Thoughts @rgentlem <https://github.com/rgentlem> @nathan-palmer <https://github.com/nathan-palmer> ? — Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC7TWA6N4M45ILYQPOPYYL3X3XP5LANCNFSM6AAAAAA5DHXARU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Robert Gentleman ***@***.***

[nathan-palmer]

Let’s put it on the backlog for a future release. NathanOn Sep 22, 2023, at 5:19 PM, Robert Gentleman ***@***.***> wrote: Hi Sam, nice work - and it might be, but at this point I would focus on getting the Minimal Viable Product (MVP) out. Add this in later if we ever find a situation where we want it. We are now at the point where seeing if we can get a user community is the most important part. That will help guide any future developments Nathan - any thoughts?

…

On Fri, Sep 22, 2023 at 3:17 PM Sam Pullman ***@***.***> wrote: If this is valuable enough information to store inside the db, I can create a new metadata table similar to Meatdata.DownloadErrors that catalogs the Variable, TableName, CodeOrValue, ValueDescription, ExpectedCount, and DBCount. Thoughts @rgentlem <https://github.com/rgentlem> @nathan-palmer <https://github.com/nathan-palmer> ? — Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC7TWA6N4M45ILYQPOPYYL3X3XP5LANCNFSM6AAAAAA5DHXARU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Robert Gentleman ***@***.*** —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>