Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'Data Group' in the tables metadata should be retrieved from nhanesManifest(variables) #19

Closed
rsgoncalves opened this issue Nov 29, 2023 · 3 comments
Assignees
Milestone

Comments

@rsgoncalves
Copy link
Contributor

No description provided.

@rsgoncalves rsgoncalves changed the title Missing Data Group for the tables should be acquired from nhanesManifest( variable ) Missing 'Data Group for the tables should be acquired from nhanesManifest( variable ) Nov 29, 2023
@rsgoncalves rsgoncalves self-assigned this Nov 29, 2023
@rsgoncalves rsgoncalves changed the title Missing 'Data Group for the tables should be acquired from nhanesManifest( variable ) Missing 'Data Group' in the tables metadata should be retrieved from nhanesManifest(variables) Nov 29, 2023
@rsgoncalves rsgoncalves added this to the v3.9.0 milestone Nov 30, 2023
@rsgoncalves
Copy link
Contributor Author

Actually nhanesManifest(variables) does not specify a data group for the tables that are missing that detail. The missing data groups were hardcoded by inspecting each one individually. Those tables that did not fit into one of the four data groups were categorized as "Documentation", such as DOC_2000, FOODLK_C and other lookup tables, etc.

@rgentlem
Copy link

rgentlem commented Dec 6, 2023 via email

@rsgoncalves rsgoncalves modified the milestones: v3.9.0, v3.8.0 Dec 6, 2023
@rsgoncalves
Copy link
Contributor Author

These tables are now included in the metadata as Deepayan identified that they exist in the Database but not in the metadata table (#11). (They are acquired using nhanesManifest().)

Some of the tables that were missing a data-group (e.g., DRXFCD_I and YDQ) I think should have regular data groups (Dietary, Questionnaire, etc.) but they are missing those details in nhanesA outputs. Others, as you said, seem to be documentation tables. But since they are all included in the database, for now our goal was to have those same tables listed/described in the metadata. If they are not useful tables, we should probably discuss removing them from the database altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants