-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sum of envelopes + example #93
base: main
Are you sure you want to change the base?
Conversation
Minor fix on bridge analysis plot envelopes. Bending moment was shown with negative sign and the y-axis was not inverted. Minor fix on "stress resultants".
As described in ccaprani#92, a new method has been implemented in class Envelopes to sum multiple envelopes. The example n.5 has been included to show a possible usage scenario.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 79.97% 82.64% +2.67%
==========================================
Files 13 13
Lines 1368 1596 +228
==========================================
+ Hits 1094 1319 +225
- Misses 274 277 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great 😃 I haven't yet looked at the notebook, but are there any tests that would make sense to add for the new functionality?
At the end of the example in the notebook I inserted a numerical control of the results between a "manual" sum of the results and the "automatic" one that comes with the use of the new function. |
Hi Colin! Have you had a look at the notebook with the example on it? |
Hi @ccaprani!
I've implemented the new method in class Envelopes to sum multiple envelopes, as described in #92, and included the example n.5 to show a possible usage scenario.
Let me know if everything is straight and clear!
Thanks.