Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sum of envelopes + example #93

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

RoccoRaimo
Copy link
Contributor

@RoccoRaimo RoccoRaimo commented May 16, 2024

Hi @ccaprani!
I've implemented the new method in class Envelopes to sum multiple envelopes, as described in #92, and included the example n.5 to show a possible usage scenario.

Let me know if everything is straight and clear!
Thanks.

RoccoRaimo and others added 4 commits May 9, 2024 14:48
Minor fix on bridge analysis plot envelopes. Bending moment was shown with negative sign and the y-axis was not inverted. Minor fix on "stress resultants".
As described in ccaprani#92, a new method has been implemented in class Envelopes to sum multiple envelopes. The example n.5 has been included to show a possible usage scenario.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 82.64%. Comparing base (9322c65) to head (66363c2).
Report is 17 commits behind head on main.

Files Patch % Lines
src/pycba/results.py 7.14% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   79.97%   82.64%   +2.67%     
==========================================
  Files          13       13              
  Lines        1368     1596     +228     
==========================================
+ Hits         1094     1319     +225     
- Misses        274      277       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ccaprani ccaprani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 😃 I haven't yet looked at the notebook, but are there any tests that would make sense to add for the new functionality?

@RoccoRaimo
Copy link
Contributor Author

RoccoRaimo commented May 16, 2024

At the end of the example in the notebook I inserted a numerical control of the results between a "manual" sum of the results and the "automatic" one that comes with the use of the new function.
Don't know if it makes sense to create a separate test. Let me know once you'll look up at the notebook :)

@RoccoRaimo
Copy link
Contributor Author

Hi Colin! Have you had a look at the notebook with the example on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants