Merge pull request #434 from discourse/firefox-alt-key

ignore Alt + <k> for Firefox
ccampbell · Mar 28, 2019 · b5b423f · b5b423f
2 parents 6833a23 + 0d41aa7
commit b5b423f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/mousetrap.js b/mousetrap.js
@@ -575,8 +575,8 @@
                 //
                 // chrome will not fire a keypress if meta or control is down
                 // safari will fire a keypress if meta or meta+shift is down
-                // firefox will fire a keypress if meta or control is down
-                if ((action == 'keypress' && !e.metaKey && !e.ctrlKey) || _modifiersMatch(modifiers, callback.modifiers)) {
+                // firefox will fire a keypress if meta, alt or control is down
+                if ((action == 'keypress' && !e.metaKey && !e.altKey && !e.ctrlKey) || _modifiersMatch(modifiers, callback.modifiers)) {
 
                     // when you bind a combination or sequence a second time it
                     // should overwrite the first one.  if a sequenceName or