-
Notifications
You must be signed in to change notification settings - Fork 197
Fix 'Copy Attribution' buttons on safari #279
Fix 'Copy Attribution' buttons on safari #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the post on Stack Overflow and this solution seems to have some issues on some versions of Safari, like a keyboard showing, and the created element being set on focus and distracting the user. I think it's better to use something like clipboard.js which already solves these problems.
Hi @brenoferreira , It's my first time to hear about clipboard.js, but I will read its docs and try to implement it. Can you give me a chance to do so? Thanks! |
Marked as in progress since @elharony is working on it. |
Hi @brenoferreira , Here are my the latest updates about
It seems to be a trade-off here. What do you think? Should we stick with the current one that might have some problems with a few Safari Versions? Or use - almost - fully supported one, and lose a major feature of the page ( Until I hear back from you, I will try to find a better alternative! 🔍 |
This is fixed in #323 |
Thanks for your support & guidance, @brenoferreira ! 🙏 |
As mentioned in #277 by @janeatcc that
Copy Attribution
buttons aren't working properly onSafari
.The problem was using the
document.execCommand("copy")
API and it isn't supported inSafari
.I tried to find a working solution for it, and I've attached a reference to it.