Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test and cleanup learner report #42

Merged
merged 3 commits into from
May 29, 2024

Conversation

brianreichtcs
Copy link
Collaborator

If approved this PR makes some changes to the library to make Client::getLearnerReport() work as expected, and shores up issues with the unit tests that came up after the fix was made and verified.

What it doesn't do:

  • Change the language of Learner Report to Enrollment Report. I will do that in a follow-up PR once this is approved and merged.
  • Make too many other changes that weren't necessary to make this work. We know the team will benefit from a working query so we can immediately determine "what's possible" via the reporting API. There are likely code and test coverage improvements to be made but I wanted to take the path of least resistance to provide a proof of concept, so I can get back to doing other things and hand this project off to the team.

@brianreichtcs brianreichtcs added bug Something isn't working enhancement New feature or request labels May 29, 2024
@brianreichtcs brianreichtcs self-assigned this May 29, 2024
@brianreichtcs brianreichtcs requested review from a team, michaelboydtcs, tomegantcs and rubenswyerstcs and removed request for a team and michaelboydtcs May 29, 2024 15:29
Copy link
Contributor

@tomegantcs tomegantcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a build process for this library to do replacements of the $version$ in file doc blocks; should we therefore drop the @version lines as well?

@brianreichtcs
Copy link
Collaborator Author

We don't have a build process for this library to do replacements of the $version$ in file doc blocks; should we therefore drop the @version lines as well?

I'll follow-up with another PR for that.

@brianreichtcs brianreichtcs merged commit a8a576d into main May 29, 2024
2 checks passed
@brianreichtcs brianreichtcs deleted the test-and-cleanup-learner-report branch May 29, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants