-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WAITING LTS Java 21] feat/java/examples : add examples #24
Draft
cboudereau
wants to merge
32
commits into
main
Choose a base branch
from
feat/java/examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cboudereau
commented
Sep 6, 2023
•
edited
Loading
edited
- remove compatibility code of JDK17
- use switch expression intead of statement
- [requires at least JDK 18] add snippets to api entrypoint Series.java
- update to LTS JDK 21 when github actions and aws will release compatible SDK to LTS 21 (maybe introduce maven toolchains to provide multiple versions of dataseries for 17 and 21 versions)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
============================================
- Coverage 98.51% 95.58% -2.93%
- Complexity 61 63 +2
============================================
Files 11 6 -5
Lines 875 204 -671
Branches 36 36
============================================
- Hits 862 195 -667
+ Misses 4 0 -4
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cboudereau
changed the title
feat/java/examples : add examples
[WAITING LTS Java 21] feat/java/examples : add examples
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.