Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAITING LTS Java 21] feat/java/examples : add examples #24

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

cboudereau
Copy link
Owner

@cboudereau cboudereau commented Sep 6, 2023

  • remove compatibility code of JDK17
  • use switch expression intead of statement
  • [requires at least JDK 18] add snippets to api entrypoint Series.java
  • update to LTS JDK 21 when github actions and aws will release compatible SDK to LTS 21 (maybe introduce maven toolchains to provide multiple versions of dataseries for 17 and 21 versions)

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.58%. Comparing base (8747ff7) to head (9947a54).

Files Patch % Lines
...in/java/io/github/cboudereau/dataseries/Union.java 81.25% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #24      +/-   ##
============================================
- Coverage     98.51%   95.58%   -2.93%     
- Complexity       61       63       +2     
============================================
  Files            11        6       -5     
  Lines           875      204     -671     
  Branches         36       36              
============================================
- Hits            862      195     -667     
+ Misses            4        0       -4     
  Partials          9        9              
Flag Coverage Δ
java 95.58% <81.25%> (+0.04%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cboudereau cboudereau changed the title feat/java/examples : add examples [WAITING LTS Java 21] feat/java/examples : add examples Sep 6, 2023
@cboudereau cboudereau marked this pull request as ready for review September 7, 2023 13:25
@cboudereau cboudereau marked this pull request as draft September 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant