-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: portal extension support #48
Open
cbochs
wants to merge
50
commits into
main
Choose a base branch
from
feat/extensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: extension support for external plugins refactor!: portal public API for more flexibility refactor!: portal iterator to be a drop-in replacement for vim.iter refactor: rename Builtin.query to Builtin.prepare
…0) as default cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Up until now, Portal relied on builtin integrations (i.e jumplist, quickfix). This is inflexible and doesn't allow external plugins to leverage Portal's API. This PR adds support for users to build their own extensions.
Breaking Changes
Note: those who are not using the Portal API directly, but instead are simply using the builtins that Portal provides should likely not experience any breakages.
max_results
aslimit
in the search optionssettings.max_results
settings.escape
table. Make this simple and quit onq
,<esc>
, and<c-c>
. Might consider adding back`source
andslots
. Instead, queries are constructed with a generating function which returns an iterable. For example,Where:
Changes
vim.iter
Portal.Query
to bridge the gap between generating and searching listsPortal.Content
to a simple object, it doesn't need to be more than thatPortal.Extension
: make it easy for users to extend PortalTodo
Builtin.tunnel