-
Notifications
You must be signed in to change notification settings - Fork 3
Do unit test and regression test #4 #35
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #35 +/- ##
===========================================
- Coverage 40.04% 37.11% -2.93%
===========================================
Files 15 17 +2
Lines 432 493 +61
===========================================
+ Hits 173 183 +10
- Misses 259 310 +51
Continue to review full report at Codecov.
|
tests/gmsh_test.cc
Outdated
const double tolerance = 1.E-12; | ||
|
||
auto mesh = std::unique_ptr<Mesh<3, 8>> (new GMSH<3, 8>()); | ||
mesh->read_mesh("../bin/regression_test.msh"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be passed as an argument? rename regression_test.msh
to a more meaningful filename of the geometry you are modelling like cube_test.msh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change the name easily... as for the argument, I checked this: https://github.com/philsquared/Catch/blob/master/docs/own-main.md
Could you explain more on how to get this? I can't seem to add int main
in regression_test.cc
file
Have added the ability to parse an argument for regression test Note that this is the way as it is still under development: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rebase to develop?
Supersede #24