Skip to content
This repository has been archived by the owner on Mar 20, 2020. It is now read-only.

Do unit test and regression test #4 #35

Merged
merged 5 commits into from
Oct 12, 2017
Merged

Do unit test and regression test #4 #35

merged 5 commits into from
Oct 12, 2017

Conversation

ezrayst
Copy link
Contributor

@ezrayst ezrayst commented Sep 25, 2017

Supersede #24

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #35 into develop will decrease coverage by 2.92%.
The diff coverage is 13.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #35      +/-   ##
===========================================
- Coverage    40.04%   37.11%   -2.93%     
===========================================
  Files           15       17       +2     
  Lines          432      493      +61     
===========================================
+ Hits           173      183      +10     
- Misses         259      310      +51
Impacted Files Coverage Δ
tests/gmsh_test.cc 2% <2%> (ø)
tests/regression_test.cc 70% <70%> (ø)
include/mesh.h 0% <0%> (ø) ⬆️
include/element.h 16.66% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4689bd...0598eb1. Read the comment docs.

@ezrayst ezrayst requested a review from kks32 September 26, 2017 16:50
const double tolerance = 1.E-12;

auto mesh = std::unique_ptr<Mesh<3, 8>> (new GMSH<3, 8>());
mesh->read_mesh("../bin/regression_test.msh");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be passed as an argument? rename regression_test.msh to a more meaningful filename of the geometry you are modelling like cube_test.msh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change the name easily... as for the argument, I checked this: https://github.com/philsquared/Catch/blob/master/docs/own-main.md

Could you explain more on how to get this? I can't seem to add int main in regression_test.cc file

@ezrayst
Copy link
Contributor Author

ezrayst commented Sep 28, 2017

Have added the ability to parse an argument for regression test

Note that this is the way as it is still under development:
catchorg/Catch2#622

Copy link
Contributor

@kks32 kks32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rebase to develop?

@kks32 kks32 merged commit 71b1ea2 into develop Oct 12, 2017
@kks32 kks32 deleted the tests branch October 12, 2017 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants