Fixes #571 #573
Merged
Fixes #571 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shuwada I think you solution still works even if we remove this line. Can you please check that? |
mkarg
referenced
this pull request
Dec 13, 2023
If a default value is assigned to a required parameter on its initialization, JCommander won't throw ParameterException even if no value is given by user. Due to this fix JCommanderTest#requiredFields1Fail did not fail anymore since Args1#verbose was a required parameter with a default value. To distinguish the two cases when a required parameter has no default value and has a default value, this commit removes the default value from Args1#verbose.
|
@shuwada @bluecontainer "ping" ;-) |
As you did not respond, I assume you silently agree. So I am merging this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #571
A default fulfills requirement, but does not count as assignment.