Never prompt for password if it was passed as an argument (fixes #195) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took the liberty of also fixing one pre-existing test related to passwords that was marked as disabled until now.
|
Having submitted this PR, even though all tests pass, I think I may have missed one option - and that is what happens when the password option is not even provided. I need to check what JCommander did in this situation until now, and make sure there's no changes due to this PR. |
|
I amended this PR to test for all possible use cases of passwords. |
|
@cbeust what do you say? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the liberty of also fixing one pre-existing test related to passwords that was marked as disabled until now.