Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New untyped stats API #723

Merged
merged 2 commits into from
Nov 25, 2023
Merged

New untyped stats API #723

merged 2 commits into from
Nov 25, 2023

Conversation

cberner
Copy link
Owner

@cberner cberner commented Nov 24, 2023

Fixes #398

@casey
Copy link
Contributor

casey commented Nov 25, 2023

Nice, that's great. This PR uses the new API. The only issue I see is that database stats are only available on write transactions, whereas open_untyped_table is only available on write transactions, so in order to get all stats, you need to open a read transaction and a write transaction.

@cberner
Copy link
Owner Author

cberner commented Nov 25, 2023

ya, I was thinking about adding open_untyped_table() to write transactions too. But then I couldn't decide whether it should return a ReadOnlyUntypedTable or an UntypedTable that might in the future have mutation methods (clear() would be an option).

@cberner cberner merged commit fa35061 into master Nov 25, 2023
3 checks passed
@cberner cberner deleted the stats branch November 25, 2023 01:45
@casey
Copy link
Contributor

casey commented Nov 25, 2023

Seems reasonable to me. Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include table stats in DatabaseStats
2 participants