fix(lsp): do not link LspInlayHint to Comment directly
#517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How it looks currently:
@sgoudham Do we need an official style guide for inlay hints? |
|
Out of topic, I saw that there is a padding-left space next to the parameter hint in your picture above, |
mrtnvgr
reviewed
Jun 21, 2023
mrtnvgr
approved these changes
Jun 21, 2023
…ound` is set Co-authored-by: mrtnvgr <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former commit links
CommenttoLspInalyHint,I think the foreground color is very proper to use,
but there is a problem,
catppuccin allows users to customize styles of comments and keywords,
if the style of comment was set to italic, which is very commonly used,
style of
LspInlayHintwould be italic too.In addition, in order to make the background color of
LspInlayHintlighter thanthe basic background color for distinction (vscode also does this),
I recommend using the background color of
CursorLine.