Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feline): disable lsp status on nightly #510

Merged
merged 4 commits into from
Jun 13, 2023
Merged

fix(feline): disable lsp status on nightly #510

merged 4 commits into from
Jun 13, 2023

Conversation

mrtnvgr
Copy link
Contributor

@mrtnvgr mrtnvgr commented Jun 13, 2023

Hotfix for #509

Copy link
Contributor

@nekowinston nekowinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for overlooking this as well, I was only testing on stable.

@rewhile
Copy link
Contributor

rewhile commented Jun 13, 2023

Please don't ever use version check unless absolutely necessary, users who don't update nightly will have issues

Should be

Lsp = vim.lsp.status and vim.lsp.status()[1] or vim.lsp.util.get_progress_messages()[1]

@rewhile
Copy link
Contributor

rewhile commented Jun 13, 2023

Also I just tested and vim.lsp.status()[1] doesn't work, did you test the PR at all before merging?

It should be vim.lsp.status() instead.

@mrtnvgr
Copy link
Contributor Author

mrtnvgr commented Jun 13, 2023

Also I just tested and vim.lsp.status()[1] doesn't work, did you test the PR at all before merging?

It should be vim.lsp.status() instead.

I couldn't test myself, so I looked for similar fixes from other repositories. I saw suggestions and assumed that others had already checked it. I'm sorry.

@rewhile
Copy link
Contributor

rewhile commented Jun 13, 2023

Seems like it still doesn't work since the new vim.lsp.status() returns 87%: Loading workspace: 82/101, Loading workspace: 83/94 instead of a { message, percentage, tittle }

@rewhile
Copy link
Contributor

rewhile commented Jun 13, 2023

The new output returns 73%: Loading workspace: 69/101, Loading workspace: 69/94 which breaks when feline do a string.format on it, i.e string.format("%:")

I think we should just disable this component on nightly instead of fighting to workaround.

@rewhile rewhile changed the title fix(feline): fix vim.fn.has statement fix(feline): disable lsp status on nightly Jun 13, 2023
@rewhile rewhile merged commit 9aaf5b4 into main Jun 13, 2023
@rewhile rewhile deleted the fix/feline-hotfix branch June 13, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants