-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: colours in diff
codeblock
#67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR.
This is an issue with the highlightjs port that got fixed recently.
The files you edited are generated, please don't edit them; we just need to bump the @catppuccin/highlightjs
dependency.
Ah, I see. I'm beginning to understand! Is it my understanding that this can be solved by simply rewriting I'm not sure if my understanding is correct, as I can't get the build to work in my local environment... > [email protected] build
> sass -I node_modules --no-charset --no-source-map catppuccin.scss:../src/bin/assets/catppuccin.css catppuccin-admonish.scss:../src/bin/assets/catppuccin-admonish.css
Error: Can't find stylesheet to import.
╷
1 │ @use "@catppuccin/palette/scss/catppuccin" as catppuccin;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
catppuccin.scss 1:1 root stylesheet
Error: Can't find stylesheet to import.
╷
3 │ @use "@catppuccin/palette/scss/catppuccin" as catppuccin;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
catppuccin-admonish.scss 3:1 root stylesheet |
Sorry, this was because I did not Also, looking closer, maybe the package is supposed to be updated on release. Sorry for the strange English! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, thanks for adjusting the PR! I think that should be it.
Hey there 👋, thanks for the pull request! The changes with the dependency bump look good, could you just help me understand why 051a7ff was reverted in |
Sorry for repeating myself... In the revert, I thought I had only undone the operations I had done, but I may have been wrong. I'm getting kind of confused.... This is a very selfish question, but what should I do in this case...? |
This reverts commit 1d10d5b.
I have tried many things, The Now all I have to do is fix the mistake in ...Please squash the messy commit history 😖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to apologise and don't worry about the commit history!
I tested out the PR locally and it looks great! I appreciate you spending the time and effort to contribute to this repo ❤️
diff
diff
codeblock
Thanks for the kind words! I was actually in a hurry for nothing as I was doing it in the time before bed.... It was a good experience 😅 |
Hello!!
I always use mdbook-catppuccin! 🐈⬛
After updating to
v1.0.0
, I noticed that the color theme is not applied correctly to thediff
.All we are doing in this PR is reverting the parameters related to diffs back to what they were before
v1.0.0
, but I think this will fix this issue.Could you please confirm this?
Thanks!! ☕