Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release suites. #564

Merged
merged 5 commits into from
Jan 7, 2020
Merged

Conversation

nuclearsandwich
Copy link
Contributor

@nuclearsandwich nuclearsandwich commented Aug 22, 2019

Cosmic, Disco, and Eoan are now live on the ROS bootstrap repository and future releases should be pushed to them as well.

The second commit removes suites older than Ubuntu Xenial and Debian Jessie.

@nuclearsandwich nuclearsandwich changed the title Add cosmic, disco, and eoan suites. Update release suites. Aug 23, 2019
@mikepurvis
Copy link
Member

mikepurvis commented Nov 1, 2019

Yakkety, Zesty, Artful, and Cosmic are all EOL as well, per: https://wiki.ubuntu.com/Releases

But I definitely agree about adding disco and eoan (though we wouldn't be able to land support for them here until osrf_pycommon supports them too: https://github.com/osrf/osrf_pycommon/blob/master/stdeb.cfg)

@wjwwood What's the policy on supporting EOL'd releases in these cases?

@nuclearsandwich
Copy link
Contributor Author

I opened the PR in bulk as I was spinning up the ROS bootstrap repositories which I had to do for all new distributions regardless of release status. If there is no demand for it I'd much prefer not releasing into distros that are already unsupported at the time of release.

@mikepurvis
Copy link
Member

@wjwwood Can we get osrf-pycommon released to disco and eoan?

@wjwwood
Copy link
Member

wjwwood commented Jan 4, 2020

Testing in eoan I think this should be fixed already. Sorry for the delay in getting back to you. I think @sloretz fixed this when preparing for Noetic and focal (20.04).

@wjwwood
Copy link
Member

wjwwood commented Jan 4, 2020

@mikepurvis I think this could just be merged.

@mikepurvis
Copy link
Member

mikepurvis commented Jan 5, 2020

Sounds good thanks. I'll push one extra commit bumping the supported Python version to 3.5, as that's the Xenial baseline (and already the minimum version per setup.py).

@dirk-thomas
Copy link
Contributor

dirk-thomas commented Jan 5, 2020

Jessie which is still listed in the suites comes with Python 3.4 afaik.

@mikepurvis
Copy link
Member

mikepurvis commented Jan 6, 2020

Huh. I'm not sure what my level of commitment is to pre-3.5 testing and validation, particularly in service of supporting oldoldstable. Perhaps jessie should just be dropped as well?

@dirk-thomas
Copy link
Contributor

Perhaps jessie should just be dropped as well?

Kinetic is still an actively supported distro and targets Jessie (see https://www.ros.org/reps/rep-0003.html#kinetic-kame-may-2016-may-2021).

@mikepurvis
Copy link
Member

mikepurvis commented Jan 6, 2020

Jessie users would still have python-catkin-tools v0.4.5, and could also pip install other versions. And catkin_tools has never really been an officially supported or recommended method of building ROS in the wiki tutorials (and has always had a per-1.0 version number), so I'm not sure it makes sense to tie its support horizon to LTS commitments on those distros.

Anyway, I don't feel strongly one way or another on this. I can bump back the Python version number to 3.4, here and in the travis testing config, but there's unlikely to be much in terms of actual support or attention to issues with it.

What is the OSRF opinion on this?

@dirk-thomas
Copy link
Contributor

What is the OSRF opinion on this?

I don't have an opinion regarding catkin_tools. I leave that up to @wjwwood.

(I would rather like to see the effort spent on adding what is missing to colcon than continue keeping catkin_tools on life support. But that is just my personal opinion.)

@mikepurvis
Copy link
Member

Colcon doesn't support Xenial or Jessie either (colcon/colcon-core#138 (comment)), which is one of the barriers for us pursuing a migration to it. :)

@dirk-thomas
Copy link
Contributor

Colcon doesn't support Xenial or Jessie either

colcon does certainly support Xenial (see https://github.com/colcon/colcon-core/blob/5b849001429cb138f3768c7fa93a8b30dd67dd25/stdeb.cfg#L4). Since it requires Python 3.5 (for all the asyncio stuff) it can't support Jessie though (assuming you don't want to install a newer Python version).

@wjwwood
Copy link
Member

wjwwood commented Jan 6, 2020

I don't have an opinion on what to do one way or the other. I doubt there are many people using catkin_tools on Debian Jessie at this point, but you could simply not release new versions of it for Jessie right? (i.e. remove jessie from the supported suites at the same time as raising the require Python version?)

I really don't see what colcon has to do with this at all.

@mikepurvis
Copy link
Member

Ah. The current master branch of catkin tools also uses asyncio. So in that case we can't support Python 3.4 regardless. So yeah, I'll drop jessie as a target.

@wjwwood
Copy link
Member

wjwwood commented Jan 6, 2020

Ah. The current master branch of catkin tools also uses asyncio. So in that case we can't support Python 3.4 regardless. So yeah, I'll drop jessie as a target.

Not that it changes what you should do imo, but asyncio was added in Python 3.3. I was stabilized in Python 3.5, but it did exist and catkin_tools supported Python 3.3 at some point.

@mikepurvis
Copy link
Member

@wjwwood The work by @jbohren to switch catkin_tools over to asyncio/trollius happened for the 0.4.0 release, in 2016. Not saying that the current source wouldn't still work on Python 3.3 or 3.4, but it's very much possible that the one that did back then was the Popen-based version.

@wjwwood
Copy link
Member

wjwwood commented Jan 6, 2020

AFAIR, catkin_tools always used asyncio for subprocess communication. That's why I wrote osrf_pycommon and that's why they depend on trollius, in order to support Python2 and older versions of Python3.

Again, doesn't really matter, I just wanted to point out that you can use asyncio before Python 3.5, because it was characterized that you could not, which is simply not true.

@mikepurvis
Copy link
Member

Cool, thanks for the clarification. I'll merge this later today if there are no objections.

@mikepurvis mikepurvis merged commit 909f6e8 into catkin:master Jan 7, 2020
@audrow audrow mentioned this pull request Jun 3, 2021
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants