Feature/416 get report data from import #982
Conversation
# Conflicts: # CHANGELOG.md
Integration Test Results322 tests 322 ✅ 1m 9s ⏱️ Results for commit 55b137b. ♻️ This comment has been updated with latest results. |
Unit Test Results215 tests 215 ✅ 20s ⏱️ Results for commit 55b137b. ♻️ This comment has been updated with latest results. |
✅ No Dependency Check findings were found |
...va/org/eclipse/tractusx/traceability/assets/application/importpoc/rest/ImportController.java
Show resolved
Hide resolved
| Map<AssetBase, Boolean> resultMap = null; | ||
| try { | ||
| resultMap = importService.importAssets(file); | ||
| resultMap = importService.importAssets(file, importJob); |
There was a problem hiding this comment.
should result map be returned in this case ? if there is job handling then I would guess service would return importJobId only . and FE would get report from that ID rather than from result map in here ?
| } catch (ImportException e) { | ||
| log.info("Could not import data", e); | ||
| importService.cancelJob(importJob); |
There was a problem hiding this comment.
same here . if there is import job that should be updated with error ( what happened ) why return error response right away ? if we want to migrate to job approach this endpoint should return either validation error for invalid format like it is doing now or job ID . then at later time FE would call job report to get report on what actually happened
| private UUID id; | ||
| private Instant startedOn; | ||
| private Instant completedOn; | ||
| private ImportJobStatus status; |
There was a problem hiding this comment.
if we go with jobID returned to FE we should consider also persisting information which entities/assets were not persisted and why. otherways user would not know what exactly happened with created job and he would only see successfully persisted entities
|
|
No description provided.