Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TRACEFOSS-XXX increase code coverage and refactor exception handling #392

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

ds-lcapellino
Copy link

No description provided.

when(edcService.initializeContractNegotiation(anyString(), any(), anyString(), any()))
.thenReturn("negotiationId");

Algorithm algorithm = Algorithm.HMAC256("Catena-X");

Check failure

Code scanning / CodeQL

Hard-coded credential in API call

Hard-coded value flows to [sensitive API call](1).
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Integration Test Results

  20 files    20 suites   56s ⏱️
166 tests 154 ✔️ 12 💤 0
170 runs  158 ✔️ 12 💤 0

Results for commit 56c49a3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Unit Test Results

205 tests   205 ✔️  1m 16s ⏱️
  52 suites      0 💤
  52 files        0

Results for commit 56c49a3.

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

[Trace-X Root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.5% 90.5% Coverage
0.0% 0.0% Duplication

Copy link

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-mwesener ds-mwesener merged commit ebe6683 into main Jul 11, 2023
@ds-mwesener ds-mwesener deleted the chore/TRACEFOSS-XXX-increase-code-coverage branch July 11, 2023 10:46
ds-lcapellino added a commit that referenced this pull request Jan 11, 2024
ds-mmaul added a commit that referenced this pull request Jan 11, 2024
ds-mmaul added a commit that referenced this pull request Jan 11, 2024
ds-mmaul added a commit that referenced this pull request Jan 11, 2024
ds-mmaul added a commit that referenced this pull request Jan 11, 2024
ds-mmaul added a commit that referenced this pull request Jan 12, 2024
ds-mmaul added a commit that referenced this pull request Jan 12, 2024
ds-mmaul added a commit that referenced this pull request Jan 12, 2024
chore(api): #392 fix multiple same requests for notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants