Chore/616 notification refactoring #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Integration Test Results330 tests 330 ✅ 1m 26s ⏱️ Results for commit af0d30e. ♻️ This comment has been updated with latest results. |
Unit Test Results210 tests 210 ✅ 17s ⏱️ Results for commit af0d30e. ♻️ This comment has been updated with latest results. |
✅ No Dependency Check findings were found |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import { ToastService } from '@shared/components/toasts/toast.service'; | ||
| import { getTranslationContext } from '@shared/helper/notification-helper'; | ||
| import { Notification, NotificationStatus } from '@shared/model/notification.model'; | ||
| import { TranslationContext } from '@shared/model/translation-context.model'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
|
|
| @ViewChild(AcceptNotificationModalComponent) acceptModal: AcceptNotificationModalComponent; | ||
| @ViewChild(AcknowledgeNotificationModalComponent) acknowledgeModal: AcknowledgeNotificationModalComponent; | ||
| @ViewChild(DeclineNotificationModalComponent) declineModal: DeclineNotificationModalComponent; | ||
| @ViewChild(NotificationActionModalComponent) notificationActionModalComponent: NotificationActionModalComponent; | ||
|
|
||
| // TODO do not delete the facade here. This will lead to a nullpointer exception within the modal call. |
There was a problem hiding this comment.
Is this really a TODO or just a hint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves eclipse-tractusx#616