Skip to content

Commit

Permalink
Merge branch 'main' into chore/436-intermediate-status-handling
Browse files Browse the repository at this point in the history
  • Loading branch information
ds-crehm authored Feb 19, 2024
2 parents f6ca153 + 1607d08 commit 1b18376
Show file tree
Hide file tree
Showing 7 changed files with 103 additions and 9 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [UNRELEASED - DD.MM.YYYY]

## [10.4.0 - 19.02.2024]

### Added
- Added tombstone icon to parts table and error description in parts detail view
- Endpoint (assets/import/report/{importJobId}) for retrieving import report
- Added concept #436: intermediate status handling
- Added add Parts view concept

### Changed
- actions/chache bumped from v3 to v4
Expand Down
3 changes: 3 additions & 0 deletions charts/traceability-foss/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.3.29] - 2024-02-19
### No changes

## [1.3.28] - 2024-02-05
### No changes

Expand Down
8 changes: 4 additions & 4 deletions charts/traceability-foss/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ home: https://eclipse-tractusx.github.io/
sources:
- https://github.com/eclipse-tractusx/traceability-foss
type: application
version: 1.3.28
appVersion: "10.3.0"
version: 1.3.29
appVersion: "10.4.0"
dependencies:
- name: frontend
repository: "file://charts/frontend"
version: 1.3.28
version: 1.3.29
- name: backend
repository: "file://charts/backend"
version: 1.3.28
version: 1.3.29
- name: postgresql
repository: https://charts.bitnami.com/bitnami
version: 12.12.10
Expand Down
4 changes: 2 additions & 2 deletions charts/traceability-foss/charts/backend/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ apiVersion: v2
name: backend
description: A Helm chart for Traceability backend application.
type: application
version: 1.3.28
appVersion: "10.3.0"
version: 1.3.29
appVersion: "10.4.0"
dependencies:
- name: postgresql
repository: https://charts.bitnami.com/bitnami
Expand Down
4 changes: 2 additions & 2 deletions charts/traceability-foss/charts/frontend/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ apiVersion: v2
name: frontend
description: A Helm chart for Traceability frontend application.
type: application
version: 1.3.28
appVersion: "10.3.0"
version: 1.3.29
appVersion: "10.4.0"
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
# Concept #621: Add Parts to notifications

| Key | Value |
|---------------|--------------------------------------------------------------------------|
| Autor | Martin Maul |
| Creation date | 08.02.2024 |
| Ticket Id | [#621](https://github.com/eclipse-tractusx/traceability-foss/issues/621) |
| State | DRAFT |

# Table of Contents
1. [Overview](#overview)
2. [Summary](#summary)
3. [Problem Statement](#problem-statement)
4. [Requirements](#requirements)
5. [NFR](#nfr)
6. [Out of scope](#out-of-scope)
7. [Assumptions](#assumptions)
8. [Concept](#concept)
9. [Glossary](#glossary)
10. [References](#references)
11. [Additional Details](#additional-details)


# Overview
The existing notification update API should allow to update partIds, as long as the status of the notification is within queued state.
# Summary
Notifications should be editable when they are not sent
# Problem Statement
Currently notifications cannot be edited when created and not sent

# Requirements
Notifications should be editable when they are not sent
For this we need a API Endpoint that can handle this.
# NFR

# Out of scope

# Assumptions

# Frontend Concept
See Miro Board for UI Mock: https://miro.com/app/board/uXjVO5JVoho=/?moveToWidget=3458764578246228901&cot=10

# Backend Concept

The Endpoint should replace the partIds of a notification by the provided partIdList.

## Endpoint:

Existing APIs will be used: **/api/alerts/:id/update** Or **/api/investigations/:id/update**
- PUT Request Method
- expected Request body:
```
{
"partIds": ["example-id1", "example-id2", ... ] // list of strings that consist of partIds
}
```
### Validation:

- Correct request structure (otherwise 400 bad Request)
- Notification exists (Otherwise 404 Not found)
- notification is in status CREATED (Otherwise 400 Bad Request)
- Notification is from owner (Otherwise status 403 Forbidden)
- Only supervisor is allowed to update the partIds of notifications.
- All partIds in request are:
- Atleast one item in partlistId list (Otherwise 400 Bad Request)
- If at least one partId is missing (400 - bad request will be thrown).
- Existing (Otherwise 404 Not found)
- in importState PERSISTENT (Otherwise 400 Bad Request)
- In bomLifeCycle asBuilt (Otherwise 400 Bad Request)
- If alert -> only own Parts (Otherwise 403 Forbidden)
- If investigation -> only other Parts (Otherwise 403 Forbidden)

### Succes Response
Update success: 204 No Content

# Glossary

| Abbreviation | Name | Description |
|--------------|------|---------------|
| | | |
| | | |

# References

# Additional Details
Given the dynamic nature of ongoing development, there might be variations between the conceptualization and the current implementation. For the latest status, refer to the documentation.
2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "trace-x",
"version": "10.3.0",
"version": "10.4.0",
"scripts": {
"analyze": "ng build --configuration=production --stats-json && webpack-bundle-analyzer dist/stats.json",
"build:prod": "ng build --output-hashing=all --configuration=debugProd --base-href /{baseHrefPlaceholder}/ --deploy-url /{baseHrefPlaceholder}/ ",
Expand Down

0 comments on commit 1b18376

Please sign in to comment.