Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#243 ess demo script #660

Merged
merged 14 commits into from
Nov 27, 2023
Merged

Feature/#243 ess demo script #660

merged 14 commits into from
Nov 27, 2023

Conversation

ds-jhartmann
Copy link

@ds-jhartmann ds-jhartmann commented Nov 21, 2023 •
edited
Loading

eclipse-tractusx#243

@github-actions GitHub Actions
Copy link

CHANGELOG file was not updated! Make sure to include important changes.

@ds-jhartmann ds-jhartmann marked this pull request as ready for review November 23, 2023 12:47
@ds-jhartmann ds-jhartmann mentioned this pull request Nov 23, 2023
Closed
10 tasks
ds-psosnowski
ds-psosnowski previously approved these changes Nov 27, 2023
View reviewed changes
Copy link

@ds-psosnowski ds-psosnowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that came to my mind is that clientId and clientSecrent is only as example data, if users are not technical, will they know where they can find it?
beside that LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ds-jhartmann ds-jhartmann merged commit 0de2ef1 into main Nov 27, 2023
@ds-jhartmann ds-jhartmann deleted the feature/#243-ESS-demo-script branch November 27, 2023 15:58
@ds-ext-kmassalski ds-ext-kmassalski mentioned this pull request Nov 30, 2023
Closed
ds-jhartmann added a commit that referenced this pull request May 21, 2024
@ds-jhartmann
Merge pull request #660 from eclipse-tractusx/dependabot/github_actio…
0f10a3e 
…ns/mikefarah/yq-4.44.1

chore(deps): bump mikefarah/yq from 4.40.5 to 4.44.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-psosnowski ds-psosnowski ds-psosnowski approved these changes

@dsmf dsmf Awaiting requested review from dsmf

@ds-ext-kmassalski ds-ext-kmassalski Awaiting requested review from ds-ext-kmassalski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds-jhartmann @ds-psosnowski