feat(registryclient):[TRI-1470] Improve registry client library #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new method to retrieve globalAssetIds for a BPN directly. This just uses the existing methods. Refactored the existing code to be more comprehensible and added some log output. The EndpointDataReference is now renewed on demand if the token expires during the runtime. Renamed DigitalTwinRegistryService#lookupShells to lookupShellIdentifiers to be more precise. The old method points to the new one and is marked as deprecated now.
|
Kudos, SonarCloud Quality Gate passed! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -24,8 +24,8 @@ | |||
|
|
|||
| /** | |||
| * Key object contains required attributes for identify part chain entry node | |||
| * @param globalAssetId Id of global asset | |||
| * @param bpn bpn of entity | |||
| * @param shellId ID of an asset administration shell (note: this is NOT a globalAssetId) | |||
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags
| * @param globalAssetId Id of global asset | ||
| * @param bpn bpn of entity | ||
| * @param shellId ID of an asset administration shell (note: this is NOT a globalAssetId) | ||
| * @param bpn the business partner number which owns the asset |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags
ds-ext-kmassalski
approved these changes
Jul 28, 2023
ds-jhartmann
approved these changes
Jul 31, 2023
ds-jhartmann
added a commit
that referenced
this pull request
Mar 1, 2024
…ments feature: 420 fix bean discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new method to retrieve globalAssetIds for a BPN directly. This just uses the existing methods.
Refactored the existing code to be more comprehensible and added some log output. The EndpointDataReference is now renewed on demand if the token expires during the runtime. Renamed DigitalTwinRegistryService#lookupShells to lookupShellIdentifiers to be more precise. The old method points to the new one and is marked as deprecated now.