Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cmp 533/externalize app config #75

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

saudkhan116
Copy link

Why we create this PR?

To externalize battery pass application configuration and make it environment independent.

What we want to achieve with this PR?

  • Add springboot configuration into helm values file
  • Add k8s configmaps
  • Mount k8s configmaps into consumer backend deployment
  • Modify consumer-backend to adapt external configuration

What is new?

Updated

  • Adapted springboot application yaml as a single source of configuration
  • Externalized the consumer-backend configuration through k8s configmaps and helm values

Deleted

  • Removed environment-specific configurations from consumer-backend

PR Linked to:

Tickets
cmp-533

@saudkhan116 saudkhan116 requested a review from matbmoser April 25, 2023 11:01
@matbmoser
Copy link

matbmoser commented Apr 27, 2023

Starting Review...

  • Reviewed and passed tests

@matbmoser
Copy link

matbmoser commented Apr 27, 2023

Review done! Awesome job @saudkhan116!!! 👍🏻 🥳 🎉

I just allowed to deploy in default mode in values.yaml file

@saudkhan116 saudkhan116 merged commit 739e9c3 into develop Apr 27, 2023
@saudkhan116 saudkhan116 deleted the feature/cmp-533/externalize-app-config branch April 27, 2023 14:58
@saudkhan116 saudkhan116 restored the feature/cmp-533/externalize-app-config branch April 28, 2023 13:05
matbmoser added a commit that referenced this pull request Jul 4, 2023
Hotfix/v1.0.0-alpha: fixed infinite loop related to get status bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants