Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cmp 988/i18n and l10n service & structure #199

Merged
merged 14 commits into from
Jan 15, 2024
Merged

Feature/cmp 988/i18n and l10n service & structure #199

merged 14 commits into from
Jan 15, 2024

Conversation

davidzynda
Copy link

Why we create this PR?

We need a translation service to have at least two languages DE and EN

PR Linked to:

https://jira.catena-x.net/browse/CMP-988

@davidzynda davidzynda changed the title i18n and l10n service i18n and l10n service & structure Dec 7, 2023
@saudkhan116 saudkhan116 added the frontend Everything related to the frontend label Dec 13, 2023
@matbmoser matbmoser added this to the v2.0.0 milestone Dec 19, 2023
@davidzynda davidzynda changed the title i18n and l10n service & structure Feature/cmp 988/i18n and l10n service & structure Dec 22, 2023
@saudkhan116 saudkhan116 changed the base branch from develop-v1.3.1 to develop December 22, 2023 14:14
@matbmoser matbmoser modified the milestones: v2.0.0, v2.1.0 Dec 22, 2023
@matbmoser
Copy link

I opened an IP issue for the libraries here now we need to wait:

@matbmoser matbmoser changed the base branch from develop-v1.4.0 to develop December 22, 2023 18:42
@matbmoser
Copy link

i updated the version of the library to v9.2.2 and there is no dependecies not approved

@matbmoser
Copy link

@davidzynda please resolve the conflicts

@matbmoser
Copy link

Also fixed an axios vulnerability here

@matbmoser
Copy link

image
Works fine !

@matbmoser
Copy link

image
With the DPP it shows like this

@matbmoser
Copy link

With the Battery it works:
image

@matbmoser
Copy link

image
The translation also works in the battery correctly

matbmoser
matbmoser suggested changes Jan 3, 2024
View reviewed changes
Copy link

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#199 (comment)

Solve this issue with the DPP and merge develop into your branch to resolve the conflicts and I can approve it :)

@matbmoser matbmoser changed the base branch from develop-old to develop January 3, 2024 17:27
saudkhan116
saudkhan116 suggested changes Jan 5, 2024
View reviewed changes
Copy link

@saudkhan116 saudkhan116 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works ok. Great Job David 👍
However, the issue mentioned in #199 (comment) need to be fixed and conflicts must be resolved

@davidzynda davidzynda merged commit c0ae264 into develop Jan 15, 2024
@davidzynda davidzynda deleted the feature/cmp-988/i18n-l10n-service branch January 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudkhan116 saudkhan116 saudkhan116 approved these changes

@dsrparracho dsrparracho Awaiting requested review from dsrparracho

@matbmoser matbmoser Awaiting requested review from matbmoser

Assignees
No one assigned
Labels
frontend Everything related to the frontend
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davidzynda @matbmoser @saudkhan116