Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup for getting started guide #5

Conversation

fmisir
Copy link
Contributor

@fmisir fmisir commented Apr 14, 2022

This PR introduces a docker-compose file based on pre build images.
The images are built currently by me locally:

EDC images are based on EDC milestone-3.1.
API Wrapper / Proxy / Backend Service is based on the "merge-aas-setup" branch.
Digital Twin Registry is the latest version from the INT environment.

As @florianrusch-zf suggested, i pushed the images to ghcr.io/catenax-ng/catenax-at-home/* they are publicly available.

I had build issues because the gradle-wrapper.jar were not available, I added them as well.

Please don't merge this yet, as it's still work in progress.

@gitguardian
Copy link

gitguardian bot commented Apr 14, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic Private Key f89169c getting-started-guide/certs/key.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@florianrusch-zf
Copy link
Contributor

[...] I had build issues because the gradle-wrapper.jar were not available, I added them as well.

if you use the gradlew.sh|.bat file it should download the jar file...or I'm wrong?

@fmisir
Copy link
Contributor Author

fmisir commented Apr 19, 2022

[...] I had build issues because the gradle-wrapper.jar were not available, I added them as well.

if you use the gradlew.sh|.bat file it should download the jar file...or I'm wrong?

The gradle-wrapper.jar is used by the gradlew.sh to download gradle. So it's required to be there.

@florianrusch-zf
Copy link
Contributor

The gradle-wrapper.jar is used by the gradlew.sh to download gradle. So it's required to be there.

Ahhh shit, okay...again learned something! Thanks!

getting-started-guide/docker-compose.yml Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@florianrusch-zf
Copy link
Contributor

@fmisir can you then also add the maven-wrapper.jar files? I also suggest a change of the .gitignore

@florianrusch-zf florianrusch-zf added the enhancement New feature or request label Apr 19, 2022
@florianrusch-zf florianrusch-zf changed the title Feature/a1 sldt 489@getting started guide Add setup for getting started guide Apr 19, 2022
@florianrusch-zf florianrusch-zf merged commit 778cdd8 into catenax-ng:merge-aas-setup Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants