Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed table separator from single-hyphen (-) to triple-hyphen (---) #30

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

arctus-io
Copy link
Contributor

@arctus-io arctus-io commented Sep 23, 2024

Changed table separator from single-hyphen (-) to triple-hyphen (---) and updated test. This change brings the resulting tables into compliance with the YouTrack Markdown implementation.

Fixes #29

@catcombo
Copy link
Owner

Hi @arctus-io !

Thank you very much for investigation and preparing the PR. YouTrack still accepts single-hyphen as a table separator, but I'm not against the changes to be fully compatible with the YouTrack documentation. Some tests are failing, but it shouldn't be a big problem to fix them. Could you also change commits messages to align with the https://www.conventionalcommits.org/en/v1.0.0/ and the commit history https://github.com/catcombo/jira2markdown/commits/master/

  • for the first commit you can use commit message feat(tables): change table header delimiter to triple hyphen
  • for the second one docs(readme): update table header conversion docs

@arctus-io arctus-io closed this Sep 27, 2024
@arctus-io arctus-io reopened this Sep 27, 2024
@arctus-io arctus-io changed the base branch from master to feature/fix-list-line-endings September 27, 2024 17:16
@arctus-io arctus-io changed the base branch from feature/fix-list-line-endings to master September 27, 2024 17:16
@arctus-io
Copy link
Contributor Author

@catcombo Thanks, for being open to changes.

I updated the remaining tests that failed and I (attempted to) fix the commit messages. Tests are passing on my side:

CI

@catcombo
Copy link
Owner

@arctus-io Looks good to me. I removed the merge commit so now we have a clean commit history. I'll merge the PR now and publish a new package version. Thank you very much!

@catcombo catcombo merged commit bd50126 into catcombo:master Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table Header Separator - is not compliant with YouTrack Markdown ---
2 participants