feat(lists): add optional space indentation for list items

[catcombo]

Fixes #9

[mfriedenhagen]

Looks reasonable.

[mfriedenhagen]

Hi @catcombo, sorry, I will not be able to test this with the "historical" code, another assignment for me and actually I do not know how to do this easily (I am using poetry and do not know how to depend on arbitrary branches there :-)).
I however looked into your test (I did code-reviews-as-job for a couple of years) and your code changes and especially the test does look very reasonable.

[catcombo]

I am using poetry and do not know how to depend on arbitrary branches there

This is actually very easy. You just need to add a line to [tool.poetry.dependencies] section of your pyproject.toml:

jira2markdown = { git = "ssh://[email protected]/catcombo/jira2markdown.git", rev = "85113701255fa1dd2f5b47285cb136e8b09c7e4c" }

85113701255fa1dd2f5b47285cb136e8b09c7e4c is the hash of the latest commit from my PR. Run poetry update jira2markdown. Create a test script:

from jira2markdown import convert

print(
    convert("""
  * One
      ** Two
 ** Three
""")
)

I however looked into your test (I did code-reviews-as-job for a couple of years) and your code changes and especially the test does look very reasonable.

I agree with you that tests should be enough. If you can't test the PR or don't have a time to do it, it's not a problem. I'll merge and publish a new release tomorrow.