move constants together #2431
Merged
move constants together #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 5, 2022 23:03
jefflembeck
approved these changes
Oct 6, 2022
|
what's the origin of the adult site part? is there a legal part to that? @pmeenan |
|
No, you can get rid of all of that. It was from when the site used Adsense for ads, they didn't allow ads to be placed on pages with "adult content" so WPT had to jump through a bunch of hoops and exclude the ad code from those test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have a single place to look for all constants
BREAKDOWN_CACHE_VERSIONandVIDEO_CODE_VERSION) sprinkled in the codebase and moved them to the newconstants.incADULT_SITEwhich is not referred to anywhereEMBEDtoconstants.incand tweaked references because it's now always defined.FRIENDLY_URLSandVER_TIMELINErequireGetSetting()fromcommon_lib.incso cannot be inconstants.inc. Moved them closer to where constants.inc is required.Tested by browsing the site with and without
?embed, e.g.https://www.webpagetest.org/video/compare.php?tests=220926_BiDcVY_E4Z-r:1-c:0-e:filmstrip&embed
vs
https://www.webpagetest.org/video/compare.php?tests=220926_BiDcVY_E4Z-r:1-c:0-e:filmstrip