Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): removing compact mode #1648

Merged
merged 2 commits into from
Dec 20, 2021
Merged

feat(design): removing compact mode #1648

merged 2 commits into from
Dec 20, 2021

Conversation

jefflembeck
Copy link
Contributor

With our responsive design overhaul, compact mode doesn't mesh well (and
isn't really necessary). It also creates more code overhead to parse/work
through.

With our responsive design overhaul, compact mode doesn't mesh well (and
isn't really necessary). It also creates more code overhead to parse/work
through.
@jefflembeck jefflembeck requested review from tkadlec and scottjehl and removed request for tkadlec December 14, 2021 19:53
Copy link
Contributor

@tkadlec tkadlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can we also kill any .compact styles in pagestyles2.css while we're at it? Just to clean it up there a bit too.

@jefflembeck jefflembeck requested a review from tkadlec December 20, 2021 15:14
@jefflembeck jefflembeck merged commit b724c99 into master Dec 20, 2021
@jefflembeck jefflembeck deleted the remove-compact-mode branch December 20, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants