Fix compilation failure when using libstdc++10 #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure case is published on https://wandbox.org/permlink/E3IuG3dbqTTDAwxv Which can be fixed by this patch as https://wandbox.org/permlink/jDqVGe2TlJ8F3Q9r This bug is caused by std::__detail::begin declared by bits/iterator_concepts.h, the function may be lookup by adl, like the case above, so here will be a matched but deleted begin, not the begin returning not_this_one This patch fixed the bug by detecting whether expression begin(std::declval<T>()) is well-formed directly
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
+ Coverage 86.80% 88.61% +1.82%
==========================================
Files 131 138 +7
Lines 3923 5603 +1680
==========================================
+ Hits 3405 4965 +1560
- Misses 518 638 +120 |
Merged
|
Thanks. |
nitnelave
pushed a commit
to nitnelave/Catch2
that referenced
this pull request
May 25, 2020
The issue is caused by deleted `std::__detail::begin` declared in `bits/iterator_concepts.h`. This would be found by ADL, and because it is deleted, compilation would fail. This change makes it so that we SFINAE on `begin(std::declval<T>())` and `end(std::declval<T>())` being well-formed.
cenit
pushed a commit
to physycom/Catch
that referenced
this pull request
Aug 8, 2020
The issue is caused by deleted `std::__detail::begin` declared in `bits/iterator_concepts.h`. This would be found by ADL, and because it is deleted, compilation would fail. This change makes it so that we SFINAE on `begin(std::declval<T>())` and `end(std::declval<T>())` being well-formed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry for my poor English, I'm not a native speaker.
The failure case is published on https://wandbox.org/permlink/E3IuG3dbqTTDAwxv
Which can be fixed by this patch as https://wandbox.org/permlink/jDqVGe2TlJ8F3Q9r
This bug is caused by std::__detail::begin declared by bits/iterator_concepts.h, the function may be lookup by adl, like the case above, so here will be a matched but deleted begin, not the begin returning not_this_one
This patch fixed the bug by detecting whether expression begin(std::declval()) is well-formed directly
The void_type is introduced because of issue mentioned here
GitHub Issues