Cohort factor lists only 25 cohorts.

[haiksu]

Cohorts are retrieved here by a call of cohort_get_all_cohorts()
https://github.com/catalyst/moodle-tool_mfa/blob/MOODLE_400_STABLE/factor/cohort/settings.php#L41

The method retrieves by default only 25 cohorts, as defined here https://github.com/moodle/moodle/blob/6374475dc3cf3a94e22ec18c4655b89819a1b5d6/cohort/lib.php#L498 (cohort_get_all_cohorts($page = 0, $perpage = 25, $search = '', $withcustomfields = false)).

The settings page should include all the cohorts, not just the first 25.

[Peterburnett]

Thanks for the investigation @haiksu . Looks like I assumed that a method called cohort_get_all_cohorts would actually get ALL cohorts... This one is legit, a Pull request to address it would be appreciated

[haiksu]

Sure, I'll get on it.

[haiksu]

Pull request here #452. Cheers!