Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use html_writer for Moodle 4.2 and lower #193

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Use html_writer for Moodle 4.2 and lower #193

merged 1 commit into from
Sep 4, 2024

Conversation

tsmilan
Copy link
Contributor

@tsmilan tsmilan commented Sep 4, 2024 •
edited
Loading

Pull request checks

  • I have checked the version numbers are correct as per the README

Fixes #192

@cameron1729 cameron1729 self-requested a review September 4, 2024 05:26
@tsmilan tsmilan changed the title Use html_writer for Moodle 4.2 and lower Use html_writer for Moodle 4.2 and lower !fixes 192 Sep 4, 2024
@tsmilan tsmilan changed the title Use html_writer for Moodle 4.2 and lower !fixes 192 Use html_writer for Moodle 4.2 and lower Sep 4, 2024
cameron1729
cameron1729 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@cameron1729 cameron1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cameron1729 cameron1729 merged commit c8b7def into MOODLE_39_STABLE Sep 4, 2024
30 checks passed
@cameron1729 cameron1729 deleted the issue_192 branch September 4, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameron1729 cameron1729 cameron1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

progress.php throws exception when using Moodle 4.2 or lower
2 participants
@tsmilan @cameron1729