Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim the input for student table search. #65

Open
andrewmadden opened this issue Nov 10, 2020 · 1 comment
Open

Trim the input for student table search. #65

andrewmadden opened this issue Nov 10, 2020 · 1 comment

Comments

@andrewmadden
Copy link
Contributor

I believe we can just add .trim() to local/assessfreq/amd/src/dashboard_quiz.js:380. Currently adding a string with a trailing space causes the search to return no results for a valid search term.
andrewmadden added a commit that referenced this issue Nov 11, 2020
@andrewmadden
Issue #65: Trim search input for student table
a3c88a5
@mattporritt
Copy link

@andrewmadden you'll need to make two PR's one for master branch and one for MOODLE_35 branch

mattporritt pushed a commit that referenced this issue Nov 11, 2020
Merge pull request #66 from catalyst/issue#65
d33a6c5 
Issue #65: Trim search input for student table
andrewmadden added a commit that referenced this issue Nov 11, 2020
@andrewmadden
Issue #65: Trim search input for student table
43aee0a
mattporritt pushed a commit that referenced this issue Nov 12, 2020
Merge pull request #67 from catalyst/issue#65-MOODLE_35
988f416 
Issue #65: Trim search input for student table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattporritt @andrewmadden