-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edited data dictionary description #3781
edited data dictionary description #3781
Conversation
For testing the documentation output, I think it will usually be preferable to run:
Which rebuilds the documentation from scratch, after removing all dynamically generated outputs, which can occasionally be leftover after a failed docs build. While running the Sphinx command directly can be faster if there's a single file you're editing and you want to see the results of your edits. The CI on GitHub will attempt to rebuild that docs from scratch with the |
Okay, noted. I'll apply this to the other pull requests I'll work on later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have a few minor wording suggestions.
Co-authored-by: E. Belfer <[email protected]>
Co-authored-by: E. Belfer <[email protected]>
Co-authored-by: E. Belfer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
@Nancy9ice Looks like there are two "line too long" errors in lines 8 and 20 of
|
Resolved! |
Hmm, docs build still seems to be failing. Did you push? |
Maybe out of scope for this PR, but @Nancy9ice I also think it would be a good idea to change the name of this data dictionary to "Raw FERC Form 1 Data Dictionary" vs. "FERC For 1 Data Dictionary" if it's not too hard. |
Sorry, I just noticed I didn't push. I've pushed it now. Please confirm that the make docs-build test now runs successfully |
I just added this and pushed it. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks @Nancy9ice
3bce7e5
Overview
Closes this Google Season of Docs Task:
There should be a description of what the Data dictionaries sub-page is about before the list
What problem does this address?
This adds descriptions for the Data dictionary sub-headings in the readthedocs to aid clarity for users.
Testing
How did you make sure this worked? How can a reviewer verify this?
I ran the command
sphinx-build -b html docs docs/_build/html
and checked if my changes reflected correctly locally@aesharpe @zaneselvans