Add generator_operating_date to 860M changelog table
#3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
added
the
schema-change
zaneselvans
approved these changes
Jul 29, 2024
zaneselvans
reviewed
Jul 29, 2024
| @@ -32,6 +32,7 @@ | |||
| "energy_source_code_1", | |||
| "energy_storage_capacity_mwh", | |||
| "fuel_type_code_pudl", | |||
| "generator_operating_date", | |||
There was a problem hiding this comment.
Given that this is the only change, I'm assuming that the column is present in the dataframe that generates this asset, and it was getting dropped when we enforce the schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3722.
What problem does this address?
Adds
generator_operating_datefrom 860M to EIA 860M changelog table.What did you change?
Added
generator_operating_dateto the table schema and made a new alembic migration.Note that this table has no downstream assets and does not get harvested, so this change will not affect any of the other EIA tables. Whereas elsewhere the
generator_operating_dateis treated as a static and harvested field, here it will originate from the referent 860M data record. This is consistent with the data in the rest of this table, which originates from 860M data only, and other attributes that are harvested from 860M data and treated as static entities in core EIA tables were already in this table (e.g., latitude and longitude). Thus, this seems like a small and straightforward fix.Testing
How did you make sure this worked? How can a reviewer verify this?
Generate the table, and make sure the
generator_operating_datecolumn is there as expected.To-do list