Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very minor but widespread formatting changes from ruff 0.3.0 #3445

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Mar 6, 2024

Overview

  • Apply ruff formatting using the newly released v0.3.0 to all files.
  • Doing this as a standalone PR to keep all the tiny one-line autoformatting changes in a single commit that we can ignore for change attribution, but adding the appropriate commit to the .git-blame-ignore-revs file can only happen after this hits main because of our squash-merge-queue.

Testing

  • pre-commit checks have passed.
  • I skimmed all of the changes and mostly it's the insertion of a blank line after module-level docstrings, plus a handful of reformatted assignment statements, which are a bit more readable.

To-do list

Preview Give feedback

@zaneselvans zaneselvans marked this pull request as ready for review March 6, 2024 20:33
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definitely makes sense to keep this as a separate PR. Looks good to merge to me.

@zaneselvans zaneselvans added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 9a34cbc Mar 6, 2024
14 checks passed
@zaneselvans zaneselvans deleted the ruff-0.3 branch March 6, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants