Force --no-cov in nightly build #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't run docs build in nightly, coverage is necessarily lower and fails our thresholds.
jdangerx
requested review from
cmgosnell,
a team,
zaneselvans and
e-belfer
and removed request for
a team and
zaneselvans
zaneselvans
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't run docs build in nightly, coverage is necessarily lower and fails our thresholds.
Overview
Closes #3381.
We added a "fail-under" threshold to our coverage configuration - which is useful to capture coverage drops. But, since we don't build the docs in nightly build, our unit/integration tests will always fail that threshold, thus failing the build.
We already calculate the coverage in CI, we don't need to do it in the nightly build.
Alternatives:
--cov-fail-under=0which effectively stops us from failing the threshold, but also is more confusingTesting
How did you make sure this worked? How can a reviewer verify this?
I'm going to run a build on this branch via GHA and see if we still fail on coverage.
To-do list