Tiny fix to make FERC to EIA tests xfail #3257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses 3 of the 4
test/integration/ferc1_eia_train_test.py::test_validate_override_fixes
tests that should XFAIL but don't as mentioned in #3251 . If we don't care about this patch to make those 3/4 tests XFAIL and just want to address the larger problem in a larger PR, then no need to merge this.What problem does this address?
The following tests should XFAIL but don't because of a small issue with how the parameters are set in the
test_validate_override_fixes
test.Based on a scan of the history with this test, I don't think these parameters have ever been correctly set, and these tests have never XFAILed, but I've never touched this test before so I'm not entirely sure.
What did you change?
Since it was a really simple change, I just updated those parameters. But that's really just a patch for the larger issue in this test, which I've moved into #3256 .
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list